Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention Multimesh custom data will be compressed to half in Compatibility #94942

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Mention Multimesh custom data will be compressed to half in Compatibility #94942

merged 1 commit into from
Aug 6, 2024

Conversation

jsjtxietian
Copy link
Contributor

For #93875

@jsjtxietian jsjtxietian requested a review from a team as a code owner July 30, 2024 07:03
@Chaosus Chaosus added this to the 4.3 milestone Jul 30, 2024
@Mickeon
Copy link
Contributor

Mickeon commented Jul 31, 2024

If you "Note" it should be put into a [b]Note[/b] like many messages of this nature.
Also may be worth documenting in more places other than this one setter (such as the corresponding getter, but there are likely more)

clayjohn
clayjohn reviewed Jul 31, 2024
View reviewed changes
doc/classes/MultiMesh.xml Outdated Show resolved Hide resolved
Mickeon
Mickeon reviewed Aug 1, 2024
View reviewed changes
doc/classes/MultiMesh.xml Outdated Show resolved Hide resolved
@jsjtxietian jsjtxietian force-pushed the multimwsh-custom branch 2 times, most recently from a4fed20 to 0396553 Compare August 1, 2024 08:24
Mickeon
Mickeon approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice as is, but I still stand by:

Also may be worth documenting in more places other than this one setter (such as the corresponding getter, but there are likely more)

@Lielay9
Copy link
Contributor

Lielay9 commented Aug 1, 2024

I'd copy the note for instance-color too. It could also be mentioned in the buffer, but since it has no description atm, it's not as important.

@akien-mga akien-mga merged commit 8c512c6 into godotengine:master Aug 6, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@jsjtxietian jsjtxietian deleted the multimwsh-custom branch August 6, 2024 11:45
@akien-mga akien-mga mentioned this pull request Aug 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mickeon Mickeon Mickeon approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
6 participants
@jsjtxietian @Mickeon @Lielay9 @akien-mga @clayjohn @Chaosus